Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize to work in glue-jupyter #41

Closed
astrofrog opened this issue Aug 11, 2023 · 1 comment · Fixed by #45
Closed

Generalize to work in glue-jupyter #41

astrofrog opened this issue Aug 11, 2023 · 1 comment · Fixed by #45

Comments

@astrofrog
Copy link
Member

While working on glue-viz/glue#2431 I noticed that glue-plotly relies a fair bit on the Qt functionality in the current version of glue-core. However, while it makes sense to add buttons etc to the Qt viewers when available, we should probably make sure that the Qt-related functionality is optional, and that the part that will convert a glue viewer state to a plotly plot can be also used in Jupyter for instance.

Anyway, this is mainly a heads-up that glue-plotly will break once glue-viz/glue#2431 is merged and that the Qt imports will need to be updated to use glue-qt, but if possible we should make those imports optional and ensure that the core functionality will work with just glue-core installed.

@Carifio24
Copy link
Member

@astrofrog This is a great point, and one that I've actually been thinking about lately. While #40 was originally just some experimentation, I came to the same conclusion re: making as much of the functionality as possible depend only on state. You can see my efforts there - I've try to mark functions that still rely on the Qt (really matplotlib) functionality by adding _from_mpl to the function name. The histogram and scatter viewers in that PR are basically functional, so maybe that should be merged in for the refactoring.

To start, though, I can update the imports like has been done in other places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants