Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Velocity shown in pixel coordinates in PV Slice View #1602

Closed
catherinezucker opened this issue Mar 12, 2018 · 4 comments · Fixed by #1615
Closed

Velocity shown in pixel coordinates in PV Slice View #1602

catherinezucker opened this issue Mar 12, 2018 · 4 comments · Fixed by #1615

Comments

@catherinezucker
Copy link

catherinezucker commented Mar 12, 2018

In the latest developer version, when a cut is made in p-v space, the velocity axis (and maybe also the position along cut axis) has units of pixels instead of units of meters per second.

pv_slice

You'll see that the velocity axis has height 630 which is the length in pixels of the velocity axis of the cube.

@astrofrog
Copy link
Member

@catherinezucker - which cube are you using? (I can't manage to reproduce this with the cubes I have)

@catherinezucker
Copy link
Author

catherinezucker commented Mar 19, 2018

Hi @astrofrog ,

I am using the 12CO COMPLETE cube of Perseus ("PerA_12coFCRAO_F_vxy.fits.gz") which can be downloaded here:

https://dataverse.harvard.edu/dataset.xhtml?persistentId=hdl:10904/10072

And here is my version info just in case!

Glue: 0.13.0.dev04425
Python: 3.6.3
PyQt4: Not installed
PyQt5: PyQt: 5.6 - Qt: 5.6.2
PySide: Not installed
qtpy: 1.4.0
setuptools: 38.5.1
numpy: 1.13.3
matplotlib: 2.2.0
pandas: 0.22.0
astropy: 3.0.1
dill: 0.2.7.1
h5py: 2.7.1
xlrd: 1.1.0
mpl-scatter-density: 0.3
glue-core: 0.13.0.dev04425
glue-exp: unknown version
glue-vispy-viewers: 0.10.dev0
glue-wwt: unknown version
IPython: 6.2.1
qtconsole: 4.3.1
ipykernel: 4.8.2
traitlets: 4.3.2
pygments: 2.2.0
pyzmq: 17.0.0
scipy: 1.0.0
scikit-image: 0.13.1
PyAVM: Not installed
spectral-cube: 0.4.2
astrodendro: Not installed
mock: Not installed
pytest: 3.4.2
plotly: 2.4.1

Thanks!

@astrofrog
Copy link
Member

@catherinezucker - I have a fix for this in #1615, which should be in the conda developer package later tomorrow. In the mean time, you can get around this by using the xyv cube instead of the vxy one. If you want to show the cube in RA/Dec and slice in velocity, the xyv cube should be a lot better performance-wise.

@catherinezucker
Copy link
Author

Thanks so much for the speedy fix, @astrofrog ! That all sounds great, but I will switch over to the xyv for good measure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants