goroutine leaks with sync.Pool

[mostynb]

github.com/klauspost/compress/zstd Encoders and Decoders leak goroutines if they're garbage collected without calling Close on them first (like sync.Pool does). It's probably not important here, but FYI in case you are doing other experiments with this library.

I have a wrapper that tries to avoid the problem: https://github.com/mostynb/zstdpool-syncpool

bazel-cache-chunking/compressor.go

Line 26 in 7aa7cb2

var zstdDefaultPool = sync.Pool{

[glukasiknuro]

Thanks for the pointer! Yeah, in this case it does not matter, in other use cases I am using https://github.com/DataDog/zstd instead because it was much more cpu friendly for decompression. I'll share some benchmarks slightly later.

[glukasiknuro]

Created benchmarks for zstd implementations, based on those benchmarks the cgo implementation is 3x times faster for compression and 6x times faster for decompression: https://github.com/glukasiknuro/go-zstd-benchmarks

Created a bug on go implementation to get insights why this benchmark results are so different than one presented on go zstd implenetation klauspost/compress#444