Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

com.gluonhq.attach.position.Parameters has a bad constructor #311

Open
nlisker opened this issue Jun 8, 2022 · 0 comments
Open

com.gluonhq.attach.position.Parameters has a bad constructor #311

nlisker opened this issue Jun 8, 2022 · 0 comments

Comments

@nlisker
Copy link

nlisker commented Jun 8, 2022

The Accuracy enum encapsulates predefined distance and time filters. Parameters can either take an Parameters (which it does), or take custom time and distance parameters. The problem is that there is a constructor that takes both an accuracy and time and distance parameters, making the accuracy meaningless.

I think that this constructor should be deprecated in favor of a (time, distance, background) constructor. getAccuracy() will return null in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant