Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite CachedOsmTileRetriever #53

Open
abhinayagarwal opened this issue Nov 30, 2020 · 0 comments
Open

Rewrite CachedOsmTileRetriever #53

abhinayagarwal opened this issue Nov 30, 2020 · 0 comments

Comments

@abhinayagarwal
Copy link
Collaborator

CachedOsmTileRetriever has multiple issues:

  1. CacheThread has an indefinite while loop. The deactivate() which is supposed to break the while loop is never called.
  2. In Osm license #52, CachedOsmTileRetriever is being updated to a non-static class. This will lead to having different instances of CacheThread writing to the same cache directory. If the PR is merged, this needs to be fixed as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@abhinayagarwal