Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for major version incrementation #89

Open
jayunit100 opened this issue Mar 25, 2014 · 1 comment
Open

support for major version incrementation #89

jayunit100 opened this issue Mar 25, 2014 · 1 comment

Comments

@jayunit100
Copy link
Contributor

Lets decide how to do major version upgrades,,,, can this be automated via commit message? Or should we even worry about it at all?

(just some brainstorming...)
Right now

  • we explicitly grep for "ci-skip in commit message".
  • we always assume only the minor version is being incremented.

Lets make these key-value pairs sent into the bash script, example:

[ci-skip="false", version="auto"] translates to
--ci-skip=false --version=auto, which results in autoincrement of minor version along with auto publishing of the new version, that way someone who wants to upgrade the major version can do

commit -m "Lets bump to 2.2 [version="2.2.0"]

and then the version, rather than auto incrmented via python script, is explicitly set in the pom.

@jayunit100
Copy link
Contributor Author

note , this is VERY low priority... because major releases are rarely implemented, and we have an easy workaround : Just turn build server off when we do a major release bump,do a pull request for the version bump, comment out the auto incrementer, and then manually run the build.

Then turn the CI back on and re-enable the auto-incrementer .

AFTER FURTHER BRAINSTORMING WITH JOHN, IM NOW OPEN TO CLOSING THIS ISSUE ENTIRELY. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant