-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
begin resetting the NTP server #23
Labels
enhancement
New feature or request
Comments
Hello. You are right. I'll make that a prior call to |
I changed my code to set the NTP server before calling begin, pointed to the dev branch and it workes perfectly. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The begin method sets the NTP server if it is called without a value. I find this behavior unintuitive and at minimum suggest that the behavior should be documented. To give an example.
NTP.setNtpServerName("asia.pool.ntp.org");
NTP.begin();
In the code above the NTP server is reset to the default by begin even though it was previously set by setNtpServerName. A better approach would be for begin to only set the NTP server value to the default is it has not already been set.
The text was updated successfully, but these errors were encountered: