Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array with red text uneditable, but shows it's value on JSON export, which renders the SOL invalid when importing the edited JSON #109

Open
orariley70 opened this issue Jul 10, 2023 · 2 comments
Assignees
Labels
awaiting-response Waiting for response

Comments

@orariley70
Copy link

orariley70 commented Jul 10, 2023

headHave array shows up as red text. Trying to edit the 15th or 16 array and importing it back will cause the resulting .sol file to appear corrupted to the application.
S7_SHARED.sol.zip

@gmariani
Copy link
Owner

gmariani commented Aug 7, 2023

I took a look at this in Firefox 115 and not sure i can replicate the issue. I opened the file and went to the headHave array. I didn't see anything in red text.

image

You said to try editing the 15th or 16th array, i assume you mean integer as in the children within the array? I edited the 15th item from a 0 to a 1 in the array and saved it.

image

image

I also re-saved the file prior to editing it and compared it to the original. Without editing, the file saved exactly the same as the original.

image

With the edit, the only difference was one byte (the value i changed).

image

At this point I don't see any reason why the application would think it's correct. If possible, please give me more details on how to replicate the issue. Step by step exactly would help. Thanks.

@gmariani gmariani self-assigned this Aug 7, 2023
@gmariani gmariani added the awaiting-response Waiting for response label Aug 7, 2023
@orariley70
Copy link
Author

Chrome 120 with guest profile so it's a brand new browser profile every time it's launched.

Steps:

  1. Use "Open" to open S7_Shared.sol
  2. search for "headhave"

Expected:
I can expand the array and show its content

Actual:
Red text on array headHave and clicking the triangle shows nothing. secHead (I think that is called?) also behaves the same
image

Regarding the app data corruption, I strongly think that the app itself has a bug preventing that only array element to be set as 1 and not detect some sort of corruption. Editing other elements in the array does work and the app won't detect the edited SOL as corrupted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-response Waiting for response
Projects
None yet
Development

No branches or pull requests

2 participants