Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feature request) automatic Number -> Integer conversion for non-decimal values imported from JSON #76

Open
wyatt8740 opened this issue Apr 22, 2018 · 4 comments
Assignees

Comments

@wyatt8740
Copy link

Importing a JSON file does not let Minerva know what data type is preferred for integer values. It appears to assign them all to the "Number" data type by default.

I would suggest either some kind of "meta data" included in the exported JSON which specifies data types, or a way to have the program automatically decide on importation.

Additionally, some kind of scripting interface so that this kind of thing could be automated by users would be nice, but it appears that the entire program is encapsulated in an anonymous function right now.

@gmariani gmariani self-assigned this Apr 27, 2018
@gmariani
Copy link
Owner

gmariani commented Aug 8, 2018

This would be very far down the road if I did do this. Minerva is made to service a dying technology and it's a side-project. To build a scripting API to automate this is a bit beyond the scope of what minerva was made to do. I can look into passing data type metadata, but again, a bit back burner, atleast for now.

@gmariani
Copy link
Owner

gmariani commented Apr 5, 2020

Yeah it's been almost two years and what i wrote then is even more true now and i haven't had time to get to this as it is. going to drop this.

@gmariani gmariani closed this as completed Apr 5, 2020
@wyatt8740
Copy link
Author

Fair enough; I understand your reasoning.

If I were to find some way you deemed elegant and did a pull request, would it have a shot at getting accepted?

@gmariani
Copy link
Owner

gmariani commented Apr 8, 2020

Sure, I'd be open to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants