V17 Billing Route Not Wokring

[hamzasgd]

InvalidArgumentException
Can only instantiate this object with a string.

[andreuka]

No route works in safari, only homepage:

"Can only instantiate this object with a string."

[BrandonR-16]

Dealing with the same thing. Not with billing, but with authenticate. Giving the exact same error.

[ghost]

give examples of code.
also write the browser you are using, the operating system, etc.

without this it is impossible to reproduce your problem

[andreuka]

@enmaboya do you using package with turbolinks?

[hamzasgd]

Found the problem missing shop parameter in the URL

[andreuka]

Found the problem missing shop parameter in the URL

do you have fix?

[hamzasgd]

Yes, I think this is not mention in upgrade guide but available in billing section of the wiki

[hamzasgd]

This is the new
{{ route('billing', ['plan' => 2, 'shop' => Auth::user()->name]) }}

[hamzasgd]

In v16 only plan param is needed

[andreuka]

This is the new
{{ route('billing', ['plan' => 2, 'shop' => Auth::user()->name]) }}

Duh, all my routes are broken when using without turbolinks.
Are you with turbolinks?

[ghost]

@enmaboya do you using package with turbolinks?

depends on the application.
some with turbolinks, some without.

all work the same.

and yes, for safari and private mode (e.g. in chrome), you need to pass the second parameter
" 'shop' => Auth::user()->name"

[andreuka]

@enmaboya do you using package with turbolinks?

depends on the application.
some with turbolinks, some without.

all work the same.

and yes, for safari and private mode (e.g. in chrome), you need to pass the second parameter
" 'shop' => Auth::user()->name"

But do you have multipages applications (server rendered) without turbolinks, right?
So all issue is we need to add shop to all links?

[BrandonR-16]

@enmaboya do you using package with turbolinks?

depends on the application.
some with turbolinks, some without.

all work the same.

and yes, for safari and private mode (e.g. in chrome), you need to pass the second parameter
" 'shop' => Auth::user()->name"

Where do you pass this parameter? Sort of new to Laravel so I'm kinda confused

[andreuka]

@enmaboya do you using package with turbolinks?

depends on the application.
some with turbolinks, some without.
all work the same.
and yes, for safari and private mode (e.g. in chrome), you need to pass the second parameter
" 'shop' => Auth::user()->name"

Where do you pass this parameter. Sort of new to Laravel so I'm kinda confused

seems like it needs to be added for all links.

[ghost]

seems like it needs to be added for all links.

No, for all other links you should have in your layout template
@include('shopify-app::partials.token_handler')

and add @sessionToken for post requests

[BrandonR-16]

seems like it needs to be added for all links.

No, for all other links you should have in your layout template
@include('shopify-app::partials.token_handler')

and add @sessionToken for post requests

Could you provide an example of where @include('shopify-app::partials.token_handler') goes in your code and how it's used?

[andreuka]

seems like it needs to be added for all links.

No, for all other links you should have in your layout template
@include('shopify-app::partials.token_handler')
and add @sessionToken for post requests

Could you provide an example of where @include('shopify-app::partials.token_handler') goes in your code and how it's used?

its included by default in latest version of package, but it doesnt solve anything when using without turbolinks for me

[BrandonR-16]

seems like it needs to be added for all links.

No, for all other links you should have in your layout template
@include('shopify-app::partials.token_handler')
and add @sessionToken for post requests

Could you provide an example of where @include('shopify-app::partials.token_handler') goes in your code and how it's used?

its included by default in latest version of package, but it doesnt solve anything when using without turbolinks for me

Yeah I'm in the same boat

[andreuka]

seems like it needs to be added for all links.

No, for all other links you should have in your layout template
@include('shopify-app::partials.token_handler')
and add @sessionToken for post requests

Could you provide an example of where @include('shopify-app::partials.token_handler') goes in your code and how it's used?

its included by default in latest version of package, but it doesnt solve anything when using without turbolinks for me

Yeah I'm in the same boat

Add ?shop=current-shop.myshopify.com to all your links, this seems to be solving issue

[ghost]

here

But, it is not necessary for billing.

---

Simply add the "shop" parameter to the route for billing

[andreuka]

here

But, it is not necessary for billing.

Simply add the "shop" parameter to the route for billing

not work out of the box for some reason :(

[andreuka]

seems like it needs to be added for all links.

No, for all other links you should have in your layout template
@include('shopify-app::partials.token_handler')
and add @sessionToken for post requests

Could you provide an example of where @include('shopify-app::partials.token_handler') goes in your code and how it's used?

its included by default in latest version of package, but it doesnt solve anything when using without turbolinks for me

Yeah I'm in the same boat

Fix with JS:

var shopOrigin = '{{ Auth::user()->name }}';

$(document).ready(function () {

    function addToQueryString(url, key, value) {
        var query = url.indexOf('?');
        var anchor = url.indexOf('#');
        if (query == url.length - 1) {
            // Strip any ? on the end of the URL
            url = url.substring(0, query);
            query = -1;
        }
        return (anchor > 0 ? url.substring(0, anchor) : url)
            + (query > 0 ? "&" + key + "=" + value : "?" + key + "=" + value)
            + (anchor > 0 ? url.substring(anchor) : "");
    }
    
    $('a[href]').each(function(){
        if(location.hostname === this.hostname || !this.hostname.length) {
            var a = $(this);
            var href = a.attr('href');
            var url = addToQueryString(href, 'shop', shopOrigin);
            a.attr('href', url);
        }
    });
});

[BrandonR-16]

That worked! Thank you so much! :)

[gnikyt]

@hamzasgd

{{ URL::tokenRoute('billing', ['plan' => 2, 'shop' => Auth::user()->name]) }}

Should work.. I should maybe auto-add shop param to append with tokenRoute...

[hamzasgd]

@hamzasgd

{{ URL::tokenRoute('billing', ['plan' => 2, 'shop' => Auth::user()->name]) }}

Should work.. I should maybe auto-add shop param to append with tokenRoute...

@osiset Yes that's a good idea.

[Kyon147]

'shop' was added automatically to Url:tokenRoute()on release V17 and PR #847 so closing this now.