updated instructions and script #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajnavarro
reviewed
Jul 13, 2023
ajnavarro
reviewed
Jul 13, 2023
README.md
Outdated
|
|
||
| please modify the the address in the script. | ||
| On production, please use a separate admin account than test1 ( g1jg8mtutu9khhfwc4nxmuhcpftf0pajdhfvsqf5 ) |
There was a problem hiding this comment.
Suggested change
| On production, please use a separate admin account than test1 ( g1jg8mtutu9khhfwc4nxmuhcpftf0pajdhfvsqf5 ) | |
| On production, please use a separate admin account than test1 ( `g1jg8mtutu9khhfwc4nxmuhcpftf0pajdhfvsqf5` ) |
ajnavarro
reviewed
Jul 13, 2023
ajnavarro
reviewed
Jul 13, 2023
ajnavarro
reviewed
Jul 17, 2023
cmd/gnodiscord/faucet.go
Outdated
Comment on lines
155
to
160
| // Print faucet contract address | ||
| // This is a hack, we should use gno.DerivePkgAddr(pkgPath string), | ||
| // I had a problem to import github.com/gnolang/gno properly. Will fix it later. | ||
| pkgAddr := crypto.AddressFromPreimage([]byte("pkgPath:" + opts.PkgPath)).Bech32() | ||
| fmt.Println("- Please verify the address with contract deloyed on chain for ", opts.PkgPath) | ||
| fmt.Println("- Please make sure deposit fund to this faucet contract: ", pkgAddr) |
waymobetta
reviewed
Jul 31, 2023
README.md
Outdated
| @@ -14,15 +14,15 @@ In addition, it adds operational complexity and cost to operating an endpoint. | |||
|
|
|||
| ### Details | |||
|
|
|||
| There are three issues we try to solve in the web-based faucet. | |||
| There are four issues we try to solve in the web-based faucet. | |||
There was a problem hiding this comment.
Consider revision:
There are four issues from the Web-Based Faucet that the Community Faucet Bot aims to solve:
- It is centralized and can be subject to abuse.
- First-time users need to submit multiple requests and are required to understand the fee structure to register and interact with the board.
-
A larger token allocation for the faucet account is needed to support a growing number of user registrations and requests to the board.
-
The faucet needs to utilize funds from a contract instead of a user account for added security and improved management going forward.
Co-authored-by: Antonio Navarro Perez <antnavper@gmail.com>
Co-authored-by: Antonio Navarro Perez <antnavper@gmail.com>
Co-authored-by: Antonio Navarro Perez <antnavper@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.