Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The new setting significantly reduce the response time for maketx addpkg and maketx call #1029

Open
piux2 opened this issue Aug 7, 2023 · 2 comments
Assignees
Labels
🐞 bug Something isn't working 📦 🌐 tendermint v2 Issues or PRs tm2 related

Comments

@piux2
Copy link
Contributor

piux2 commented Aug 7, 2023

Description

#969
a11a07f

This setting introduced significant 1 - 2 seconds delay in response to gnokey maketx addpkg and gnokey maketx call

It's parent commit does not have issue. gnokey got instant responses
72a5732

Tested locally with single instant and started gno.land instance with fresh state

@moul moul added 📦 🌐 tendermint v2 Issues or PRs tm2 related 🐞 bug Something isn't working labels Aug 9, 2023
@moul
Copy link
Member

moul commented Aug 9, 2023

Good case for someone who wants to dig more tm2. Who would like to give a try?

@zivkovicmilos zivkovicmilos self-assigned this Aug 9, 2023
@zivkovicmilos
Copy link
Member

PR #969 introduced a fixed block time interval

Any command that adds transactions to the mempool will now have to wait for the block to be included in the chain, this is why you're experiencing a delay for the response (they do a broadcast_commit, so it's blocking)

I will look into how we can optimize this UX, so will keep the issue open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 📦 🌐 tendermint v2 Issues or PRs tm2 related
Projects
Status: 🚀 Needed for Launch
Development

No branches or pull requests

3 participants