Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: value decl loop #2074

Merged
merged 12 commits into from
Sep 12, 2024
Merged

fix: value decl loop #2074

merged 12 commits into from
Sep 12, 2024

Conversation

petar-dambovaliev
Copy link
Contributor

@petar-dambovaliev petar-dambovaliev commented May 11, 2024

fixes this by splitting value declarations with multiple values into single declarations with a single value.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs

@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label May 11, 2024
Copy link

codecov bot commented May 11, 2024

Codecov Report

Attention: Patch coverage is 89.28571% with 3 lines in your changes missing coverage. Please review.

Project coverage is 60.51%. Comparing base (f04ec89) to head (9b64257).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
gnovm/pkg/gnolang/preprocess.go 89.28% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2074      +/-   ##
==========================================
+ Coverage   60.44%   60.51%   +0.06%     
==========================================
  Files         563      563              
  Lines       75159    75363     +204     
==========================================
+ Hits        45427    45603     +176     
- Misses      26343    26369      +26     
- Partials     3389     3391       +2     
Flag Coverage Δ
contribs/gnodev 60.65% <ø> (-0.82%) ⬇️
contribs/gnofaucet 15.31% <ø> (ø)
gno.land 67.21% <ø> (ø)
gnovm 64.54% <92.59%> (+0.07%) ⬆️
misc/genstd 80.54% <ø> (ø)
misc/logos 19.88% <ø> (ø)
tm2 62.00% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the 📦 🌐 tendermint v2 Issues or PRs tm2 related label May 11, 2024
@petar-dambovaliev petar-dambovaliev marked this pull request as ready for review May 12, 2024 11:20
tm2/pkg/crypto/bip39/bip39.go Outdated Show resolved Hide resolved
gnovm/pkg/gnolang/preprocess.go Outdated Show resolved Hide resolved
.github/golangci.yml Outdated Show resolved Hide resolved
@zivkovicmilos
Copy link
Member

@petar-dambovaliev
Can you please pull in the latest master changes? 🙏
We've overhauled the CI, so it should be much quicker

gnovm/pkg/gnolang/preprocess.go Outdated Show resolved Hide resolved
gnovm/pkg/gnolang/preprocess.go Show resolved Hide resolved
@thehowl thehowl merged commit aa4bc99 into master Sep 12, 2024
119 checks passed
@thehowl thehowl deleted the varloop2 branch September 12, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

bug: var declaration definition loop
5 participants