Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gnoland] Improve UX of genesis txs remove command #2304

Open
leohhhn opened this issue Jun 7, 2024 · 2 comments
Open

[gnoland] Improve UX of genesis txs remove command #2304

leohhhn opened this issue Jun 7, 2024 · 2 comments

Comments

@leohhhn
Copy link
Contributor

leohhhn commented Jun 7, 2024

Description

The gnoland genesis txs remove command takes in a hash of a transaction. The only way to get the hash of a transaction currently is to fetch the block that it was included in and find it inside.

ClsKCi92bS5tX2NhbGwSTQooZzFqZzhtdHV0dTlraGhmd2M0bnhtdWhjcGZ0ZjBwYWpkaGZ2c3FmNRoUZ25vLmxhbmQvci9kZW1vL2VjaG8iBlJlbmRlcioDbG9sEhMIgNrECRIMMTAwMDAwMHVnbm90Gn4KOgoTL3RtLlB1YktleVNlY3AyNTZrMRIjCiED4WE22xceMt9ImTWUHwVuIviYY+NznQq3zUnsQoOcnbISQLZ8rBnYX2iEVQwfrdNW4uYXdamoHKP58P6V9MRWsQVTBjEdjEafIX27XVUbFv/uc/mBTrARL1RV0qH26Hi8uLw=

On top of this, just giving the subcommand the value from above found in the fetched block, would not work - and even getting the hex representation, which is below, would also not work.

436c734b436939326253357458324e686247775354516f6f5a7a46715a7a68746448563064546c726147686d64324d30626e68746457686a63475a305a6a42775957706b61475a326333466d4e526f555a3235764c6d7868626d51766369396b5a5731764c32566a61473869426c4a6c626d526c63696f446247397345684d49674e72454352494d4d5441774d4441774d48566e626d3930476e344b4f676f544c3352744c6c4231596b746c65564e6c593341794e545a724d52496a4369454434574532327863654d7439496d5457554877567549766959592b4e7a6e5171337a556e73516f4f636e624953514c5a3872426e59583269455651776672644e573475595864616d6f484b503538503656394d525773515654426a45646a456166495832375856556246762f75632f6d42547241524c3152563071483236486938754c773d

We should find a simpler way to execute this subcommand, because if this doesn't happen, people will simply go in and remove the transaction manually, which could cause human errors, and ultimately make the subcommand useless.

@leohhhn
Copy link
Contributor Author

leohhhn commented Jun 7, 2024

Possibly related to this in regards to amino encoding/decoding

@linhpn99
Copy link
Contributor

linhpn99 commented Jun 8, 2024

Description

The gnoland genesis txs remove command takes in a hash of a transaction. The only way to get the hash of a transaction currently is to fetch the block that it was included in and find it inside.

ClsKCi92bS5tX2NhbGwSTQooZzFqZzhtdHV0dTlraGhmd2M0bnhtdWhjcGZ0ZjBwYWpkaGZ2c3FmNRoUZ25vLmxhbmQvci9kZW1vL2VjaG8iBlJlbmRlcioDbG9sEhMIgNrECRIMMTAwMDAwMHVnbm90Gn4KOgoTL3RtLlB1YktleVNlY3AyNTZrMRIjCiED4WE22xceMt9ImTWUHwVuIviYY+NznQq3zUnsQoOcnbISQLZ8rBnYX2iEVQwfrdNW4uYXdamoHKP58P6V9MRWsQVTBjEdjEafIX27XVUbFv/uc/mBTrARL1RV0qH26Hi8uLw=

On top of this, just giving the subcommand the value from above found in the fetched block, would not work - and even getting the hex representation, which is below, would also not work.

436c734b436939326253357458324e686247775354516f6f5a7a46715a7a68746448563064546c726147686d64324d30626e68746457686a63475a305a6a42775957706b61475a326333466d4e526f555a3235764c6d7868626d51766369396b5a5731764c32566a61473869426c4a6c626d526c63696f446247397345684d49674e72454352494d4d5441774d4441774d48566e626d3930476e344b4f676f544c3352744c6c4231596b746c65564e6c593341794e545a724d52496a4369454434574532327863654d7439496d5457554877567549766959592b4e7a6e5171337a556e73516f4f636e624953514c5a3872426e59583269455651776672644e573475595864616d6f484b503538503656394d525773515654426a45646a456166495832375856556246762f75632f6d42547241524c3152563071483236486938754c773d

We should find a simpler way to execute this subcommand, because if this doesn't happen, people will simply go in and remove the transaction manually, which could cause human errors, and ultimately make the subcommand useless.

I think we should have an ID for each transaction in genesis_txs.jsonl, and the subcommand should interact with this ID instead of finding or calculating the hash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

2 participants