feat: add player stats for raffle #173
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for gnochess-signup-form canceled.
|
✅ Deploy Preview for gnochess canceled.
|
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Signed-off-by: moul <94029+moul@users.noreply.github.com>
moul
force-pushed
the
dev/moul/stats
branch
from
84d10ed
to
31a0c51
Compare
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Signed-off-by: moul <94029+moul@users.noreply.github.com>
tbruyelle
reviewed
Sep 27, 2023
| return res.(*playerStats) | ||
| } | ||
|
|
||
| newStats := playerStats{} |
There was a problem hiding this comment.
Why not
newStats := playerStats{Addr: addr} ?
And so why doing that in the public function instead (line 50) ?
There was a problem hiding this comment.
to save on storage since the address is already known by the avl.Tree; but I'm okay to move to your solution too. Feel free to patch my PR if you prefer 👍
There was a problem hiding this comment.
No that's fine, it's also good to save storage!
tbruyelle
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #159.
This will compute stats from games, that can be fetched from other contracts to build onchain raffles.