Skip to content

Commit 0d4a20e

Browse files
marinaciocea-zzCQ Bot
authored and
CQ Bot
committed
[dhcpv6] Re-enable test broken by float arithmetic
Re-enable tests that were disabled due to floating-point arithmetic changes in the rust standard library. The behavior of floating-point arithmetic went back to rounding vs truncating in rust-lang/rust#96051, so it's safe to enable these tests again. A new bug has been filed to track the work to avoid doing floating-point arithmetic. The complication is that `StepRng` is behaving in unexpected ways and preventing migration of the existing unit tests. Fixed: 92923 Bug: 102199 Change-Id: I3372193a8d59f1bc0d816e9921056bb85fb290d4 Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/643581 Reviewed-by: Jake Fried <friedj@google.com> Reviewed-by: Ghanan Gowripalan <ghanan@google.com> Commit-Queue: Tony Gong <gongt@google.com>
1 parent efd151c commit 0d4a20e

File tree

1 file changed

+0
-1
lines changed
  • src/connectivity/network/dhcpv6/core/src

1 file changed

+0
-1
lines changed

src/connectivity/network/dhcpv6/core/src/client.rs

-1
Original file line numberDiff line numberDiff line change
@@ -5290,7 +5290,6 @@ mod tests {
52905290
// NOTE: All comparisons are done on millisecond, so this test is not affected by precision
52915291
// loss from floating point arithmetic.
52925292
#[test]
5293-
#[ignore]
52945293
fn retransmission_timeout() {
52955294
let mut rng = StepRng::new(std::u64::MAX / 2, 0);
52965295

0 commit comments

Comments
 (0)