Skip to content

Commit 9656bab

Browse files
tmandrygnoliyil
authored andcommitted
[rust] Enable v0 symbol mangling by default
This was stabilized toward the beginning of 2022 (rust-lang/rust#90128), though it still isn't the default used by the compiler. Fuchsia tooling should know how to demangle Rust symbols by now (except for tools that already don't work with the legacy mangling scheme, http://fxbug.dev/64315). Test: Manually verified that zxdb can symbolize backtraces when this option is enabled. Fixed: 57302 Change-Id: If0284671499af04194ab6033a3b7c54cf2314cd2 Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/769822 Reviewed-by: Joseph Ryan <josephry@google.com> Commit-Queue: Tyler Mandry <tmandry@google.com> Fuchsia-Auto-Submit: Tyler Mandry <tmandry@google.com> Reviewed-by: David Koloski <dkoloski@google.com> Reviewed-by: Dangyi Liu <dangyi@google.com>
1 parent c6fb376 commit 9656bab

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

build/config/rust/BUILD.gn

+1-4
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,7 @@ import("//build/toolchain/rbe.gni")
2222
declare_args() {
2323
# Controls whether the rust compiler uses v0 symbol mangling scheme
2424
# (see https://github.com/rust-lang/rfcs/blob/HEAD/text/2603-rust-symbol-name-mangling-v0.md).
25-
# The v0 symbol mangling scheme requires upstream LLVM support when demangling,
26-
# so it is not on by default.
27-
# TODO(fxbug.dev/57302): Enable v0 mangling by default.
28-
rust_v0_symbol_mangling = false
25+
rust_v0_symbol_mangling = true
2926

3027
# Enable incremental rust compilation. Takes a path to the directory to use
3128
# as the cache.

0 commit comments

Comments
 (0)