New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation about `deposit` and `approve` #116

Open

cag opened this issue Apr 5, 2018 · 0 comments

Labels

Contributor

cag commented Apr 5, 2018

In #109 from @srameshr came the following question:

Also what does the following do?

        [gnosis.etherToken.constructor, await gnosis.etherToken.deposit.sendTransaction({ value: depositValue })],
        [gnosis.etherToken.constructor, await gnosis.etherToken.approve.sendTransaction(event.address, depositValue)],
        [event.constructor, await event.buyAllOutcomes.sendTransaction(depositValue)],

What is deposit, approve doing here? Assume intention of the user here is just to buy some tokens and nothing else.

Information answering that question should be included in the docs.

cag added the help wanted label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment