Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy task removed? #30

Closed
clemsos opened this issue Sep 5, 2024 · 4 comments
Closed

Deploy task removed? #30

clemsos opened this issue Sep 5, 2024 · 4 comments

Comments

@clemsos
Copy link

clemsos commented Sep 5, 2024

Hi, I have been using delay modules on various chains but it seems you have removed the yarn deploy task and the corresponding hardhat script. There may be a good reason for it, but what will be the best way to deploy the contract from a script now ?

@samepant
Copy link
Contributor

samepant commented Sep 9, 2024

we refactored the deploy script to make verification easier — you should be able to deploy with yarn deploy:mastercopies [network] now, although you may need to modify it a bit for custom networks.

changes were made here with more info: https://github.com/gnosisguild/zodiac-modifier-delay/pull/29/files#diff-281338bc1638d32f212389de68eeee9db1730602b9551d81eb569ee97f683249

@clemsos
Copy link
Author

clemsos commented Sep 10, 2024

Thank you @samepant for the answer. My goal here is to deploy an instance of the Delay safe plugin on a network where the master copy already exists (such as mainnet).

It seems that the deploy master copy task is for network where the Delay contract hasn't been deployed yet. Or am I misunderstanding the meaning of "master" here ?

@samepant
Copy link
Contributor

hey @clemsos i misunderstood what you were asking, sorry!

to deploy a new delay module use our new zodiac-core package. there is a function in there called deployProxy, which can be used to deploy new instances of the mastercopies (you'll need the mastercopy address, a salt and a provider)

we are still working on improving all this tooling, let us know if you have feedback :)

@clemsos
Copy link
Author

clemsos commented Sep 11, 2024

No worries, my demand wasn't very clear in the first place. Anyways that worked 👍 Sidenote, I am using the Connext plugin and that one hasnt been migrated to the new format yet. thank you very much !

@clemsos clemsos closed this as completed Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants