Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Migration to Zodiac Core and Task Improvements in the Reality Mod #81

Merged
merged 6 commits into from
Sep 12, 2024

Conversation

juliopavila
Copy link
Contributor

Description:

This Pull Request focuses on the integration of the new Zodiac Core package across the Reality module. The key objective is to replace the previous Gnosis Zodiac dependencies with the newly established Zodiac Core to enhance modularity and reduce tightly coupled dependencies.

Key Changes:

  1. Migration to Zodiac Core:

    • Replaced all previous imports from @gnosis.pm/zodiac with the new @gnosis-guild/zodiac-core.
    • Updated the contracts to reflect these changes.
  2. Task Improvements:

    • Added new tasks for deploying and verifying mastercopies, leveraging the modular approach from Zodiac Core:
      • deploy:mastercopies: Deploys all mastercopies.
      • deploy:mastercopy --contract-version <version>: Deploys a specific version of a mastercopy.
      • verify:mastercopies: Verifies all mastercopies.
      • verify:mastercopy --contract-version <version>: Verifies a specific version of a mastercopy.
    • Removed outdated task files and reorganized task scripts for clarity and maintainability.
  3. Configuration Updates:

    • Updated the Hardhat configuration to include the necessary setups for the new tasks and dependencies.
    • Modified hardhat.config.ts to import new task files and include new network configurations like Sepolia.
  4. Package and Dependency Upgrades:

    • Upgraded various npm dependencies to their latest versions, including Hardhat plugins and TypeScript.
    • Introduced the latest version of @gnosis-guild/zodiac-core and removed the old Zodiac dependencies.
  5. Test Suite Updates:

    • Modified existing tests to be compatible with the new Zodiac Core structure.
    • Updated assertions in all the specs files to ensure they work with the refactored contract logic.

Solution:

The solution involved refactoring existing contracts and tasks to use Zodiac Core. This makes the system more modular and reduces the risk of introducing bugs during future updates. The new approach also enhances the clarity of the codebase, making it easier for developers to work with.

@juliopavila juliopavila changed the title Feat: Migration to Zodiac Core and Task Improvements in Reality Mod Feat: Migration to Zodiac Core and Task Improvements in the Reality Mod Sep 9, 2024
Copy link
Contributor

github-actions bot commented Sep 9, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@juliopavila
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@samepant samepant merged commit b63ada4 into main Sep 12, 2024
3 checks passed
@samepant samepant deleted the use-zodiac-core branch September 12, 2024 14:18
@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants