Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for provider: Volcano Engine #2279

Closed
3 of 5 tasks
liuruibin opened this issue Sep 19, 2024 · 9 comments · Fixed by #2282
Closed
3 of 5 tasks

Support for provider: Volcano Engine #2279

liuruibin opened this issue Sep 19, 2024 · 9 comments · Fixed by #2282

Comments

@liuruibin
Copy link
Contributor

Welcome

  • Yes, I've searched similar issues on GitHub and didn't find any.
  • Yes, the DNS provider exposes a public API.
  • Yes, I know that the lego maintainers don't have an account in all DNS providers in the world.
  • Yes, I'm able to create a pull request and be able to maintain the implementation.
  • Yes, I'm able to test an implementation if someone creates a pull request to add the support of this DNS provider.

How do you use lego?

Library

Link to the DNS provider

https://www.volcengine.com/docs/6420/192724

Link to the API documentation

https://www.volcengine.com/docs/6420/192724

Additional Notes

Does TrafficRoute DNS have a support plan?

@ldez ldez changed the title Support for provider: <put the name of your provider> Support for provider: volcengine/TrafficRoute Sep 19, 2024
@ldez
Copy link
Member

ldez commented Sep 19, 2024

Hello,

https://www.volcengine.com/docs/6420/192724

This is a link to the documentation of a UI.

You provided no link to the API, so guess there is no API, and no link to the DNS provider itself.

  • Yes, I'm able to create a pull request and be able to maintain the implementation.
  • Yes, I'm able to test an implementation if someone creates a pull request to add the support of this DNS provider.

You are neither able to create nor test a PR, and as we don't have a Volcano Engine account, it will be difficult to do something.


I found this SDK: https://github.com/volcengine/volc-sdk-golang

Based on the information from this issue, it will be difficult to work on this.

We need someone who can either create a PR or test a PR.

@ldez ldez changed the title Support for provider: volcengine/TrafficRoute Support for provider: volcengine Sep 19, 2024
@ldez ldez changed the title Support for provider: volcengine Support for provider: volcano engine / volcengine Sep 19, 2024
@ldez ldez changed the title Support for provider: volcano engine / volcengine Support for provider: Volcano Engine Sep 20, 2024
@ldez
Copy link
Member

ldez commented Sep 20, 2024

@liuruibin can you try PR #2282?

Ask me if you need help to test it.

@ldez
Copy link
Member

ldez commented Sep 22, 2024

@liuruibin can you answer, please?

Creating an issue is the first step, but I need a user to test the implementation.
I can help you to learn how to test the PR.

@ldez
Copy link
Member

ldez commented Sep 24, 2024

@liuruibin any news?

@liuruibin
Copy link
Contributor Author

@liuruibin any news?

Thanks, I will test this feature in 1Panel

@ldez
Copy link
Member

ldez commented Sep 27, 2024

Can you test it as requested inside the PR description?

#2282 (comment)

@ldez
Copy link
Member

ldez commented Sep 30, 2024

@liuruibin any news?

@liuruibin

This comment was marked as outdated.

@ldez ldez closed this as completed in #2282 Oct 7, 2024
@liuruibin

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants