Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infra for single-target notifs #44

Merged
merged 10 commits into from
Aug 9, 2024
Merged

infra for single-target notifs #44

merged 10 commits into from
Aug 9, 2024

Conversation

debjit-bhowal-rs
Copy link
Contributor

fixes #43

@debjit-bhowal-rs debjit-bhowal-rs changed the title Deb/push notifs infra for single-target notifs Aug 8, 2024
komal-sai-yral
komal-sai-yral requested changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@komal-sai-yral komal-sai-yral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall correctness looks good. Thanks for putting extra effort to clean the codebase. Added some comments

src/events/event.rs Outdated Show resolved Hide resolved
src/events/push_notifications.rs Outdated Show resolved Hide resolved
src/events/push_notifications.rs Outdated Show resolved Hide resolved
src/events/push_notifications.rs Outdated Show resolved Hide resolved
src/events/push_notifications.rs Outdated Show resolved Hide resolved
debjit-bhowal-rs
debjit-bhowal-rs commented Aug 9, 2024
View reviewed changes
Copy link
Contributor Author

@debjit-bhowal-rs debjit-bhowal-rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@komal-rs

komal-sai-yral
komal-sai-yral requested changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@komal-sai-yral komal-sai-yral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor edit request. overall looks good. Tested in my local, working fine

src/events/event.rs Outdated Show resolved Hide resolved
@komal-sai-yral komal-sai-yral merged commit 9ed9a90 into main Aug 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@komal-sai-yral komal-sai-yral komal-sai-yral requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Infrastructure for PNs in YRAL
2 participants
@debjit-bhowal-rs @komal-sai-yral