Skip to content
This repository has been archived by the owner on Mar 11, 2024. It is now read-only.

Make command registration goroutine safe #77

Open
toolateforteddy opened this issue Jul 17, 2018 · 0 comments
Open

Make command registration goroutine safe #77

toolateforteddy opened this issue Jul 17, 2018 · 0 comments
Assignees

Comments

@toolateforteddy
Copy link
Contributor

We should add a mutex around all places that register commands. By doing so, it would be much easer to register functions dynamically.

For example:
!send-periodically "I like cats" "0 0 0 * * *"
Would then send, in the current channel, "I like cats" at midnight every day.

I am sure more interesting things will be considered by allowing dynamic registration of commands, and making the registration threadsafe is just the first step to enable that excellence.

@fabioxgn fabioxgn self-assigned this Oct 6, 2018
@fabioxgn fabioxgn changed the title Make command registration thread safe Make command registration goroutine safe Oct 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants