Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Token signature support for RSA and ECDSA algorithms #10

Open
Shadowfaxenator opened this issue Nov 21, 2023 · 1 comment · May be fixed by #11
Open

Token signature support for RSA and ECDSA algorithms #10

Shadowfaxenator opened this issue Nov 21, 2023 · 1 comment · May be fixed by #11

Comments

@Shadowfaxenator
Copy link

Currently tokens are signed using only one crypto algorithm. Please add RSA and ECDSA algorithms as symmetric crypto keys are not really suitable for OAuth
@pheelee
Copy link

pheelee commented Nov 23, 2023

Hi
I'm currently working on a pull request to implement more TokenSecureFormatter's because the default SHA256 then RC4 is not secure at all.

It really depends on the application what crypto algorithm should be used an I think this is why the autor implemented just 1 and provided an interface to extend. Nevertheless my list to implement is the following:

  • AES128 GCM
  • AES256 GCM
  • RSA-OAEP
  • HMAC SHA256

@pheelee pheelee linked a pull request Feb 5, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add more secure token formatters pheelee/oauth
2 participants
@pheelee @Shadowfaxenator