Delete deleted release attachments immediately from storage (#23913) (#23958)

GiteaBot · lunny · web-flow · commit 001d3fb82093 · 2023-04-06T18:38:34.000-04:00
Backport #23913 by @lunny Previously, deleted release attachments were kept forever on the external storage. Note: It may be very slow now if there are many attachments to be deleted on this release. Fix #23728 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
diff --git a/services/release/release.go b/services/release/release.go
@@ -227,7 +227,7 @@ func UpdateRelease(doer *user_model.User, gitRepo *git.Repository, rel *repo_mod
 			deletedUUIDs.Add(attach.UUID)
 		}
 
-		if _, err := repo_model.DeleteAttachments(ctx, attachments, false); err != nil {
+		if _, err := repo_model.DeleteAttachments(ctx, attachments, true); err != nil {
 			return fmt.Errorf("DeleteAttachments [uuids: %v]: %w", delAttachmentUUIDs, err)
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -227,7 +227,7 @@ func UpdateRelease(doer user_model.User, gitRepo git.Repository, rel *repo_mod`
`227`	`227`	`deletedUUIDs.Add(attach.UUID)`
`228`	`228`	`}`
`229`	`229`
`230`		`- if _, err := repo_model.DeleteAttachments(ctx, attachments, false); err != nil {`
	`230`	`+ if _, err := repo_model.DeleteAttachments(ctx, attachments, true); err != nil {`
`231`	`231`	`return fmt.Errorf("DeleteAttachments [uuids: %v]: %w", delAttachmentUUIDs, err)`
`232`	`232`	`}`
`233`	`233`	`}`