Skip to content

Commit

Permalink
Upgrade to Node 20 on CI, enable actions cancellation (#24524)
Browse files Browse the repository at this point in the history
- Upgrade node, the
[snap](https://github.com/go-gitea/gitea/blob/7abe958f5b507efa676fb3b2e27d30517f6d1908/snap/snapcraft.yaml#L47)
is excluded from this because [there is no Node 20 snap
yet](https://snapcraft.io/node).
- Add actions build cancellation based on
[this](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-using-a-fallback-value).

---------

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
  • Loading branch information
silverwind and techknowlogick authored May 4, 2023
1 parent 747e9f7 commit 0ca1958
Show file tree
Hide file tree
Showing 6 changed files with 29 additions and 9 deletions.
8 changes: 4 additions & 4 deletions .drone.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ steps:
- git fetch --tags --force

- name: deps-frontend
image: node:18
image: node:20
pull: always
commands:
- make deps-frontend
Expand All @@ -51,7 +51,7 @@ steps:
image: techknowlogick/xgo:go-1.20.x
pull: always
commands:
# Upgrade to node 18 once https://github.com/techknowlogick/xgo/issues/163 is resolved
# Upgrade to node 20 once https://github.com/techknowlogick/xgo/issues/163 is resolved
- curl -sL https://deb.nodesource.com/setup_16.x | bash - && apt-get -qqy install nodejs
- export PATH=$PATH:$GOPATH/bin
- make release
Expand Down Expand Up @@ -161,7 +161,7 @@ steps:
- git fetch --tags --force

- name: deps-frontend
image: node:18
image: node:20
pull: always
commands:
- make deps-frontend
Expand All @@ -179,7 +179,7 @@ steps:
image: techknowlogick/xgo:go-1.20.x
pull: always
commands:
# Upgrade to node 18 once https://github.com/techknowlogick/xgo/issues/163 is resolved
# Upgrade to node 20 once https://github.com/techknowlogick/xgo/issues/163 is resolved
- curl -sL https://deb.nodesource.com/setup_16.x | bash - && apt-get -qqy install nodejs
- export PATH=$PATH:$GOPATH/bin
- make release
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/pull-compliance.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@ name: "Pull: Compliance Tests"

on: [pull_request]

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
cancel-in-progress: true

jobs:
lint_basic:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -79,7 +83,7 @@ jobs:
- name: setup node
uses: actions/setup-node@v3
with:
node-version: 18
node-version: 20
- name: deps-frontend
run: make deps-frontend
- name: lint frontend
Expand All @@ -100,7 +104,7 @@ jobs:
- name: setup node
uses: actions/setup-node@v3
with:
node-version: 18
node-version: 20
- name: deps-backend
run: make deps-backend deps-tools
- name: deps-frontend
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/pull-compliance_docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,20 @@ on:
- "docs/**"
- "*.md"

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
cancel-in-progress: true

jobs:
compliance-docs:
runs-on: ubuntu-latest
steps:
- name: checkout
uses: actions/checkout@v3
- name: setup node
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: 18
node-version: 20
- name: install dependencies
run: make deps-frontend
- name: lint markdown
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/pull-db_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@ name: "Pull: Database Tests"

on: [pull_request]

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
cancel-in-progress: true

jobs:
# PostgreSQL Tests
db_pgsql_test:
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/pull-docker_dryrun.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@ name: "Pull: Docker Dry Run"

on: [pull_request]

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
cancel-in-progress: true

jobs:
docker_dryrun:
runs-on: ubuntu-latest
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/pull-e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@ name: "Pull: E2E Tests"

on: [pull_request]

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
cancel-in-progress: true

jobs:
e2e_tests:
runs-on: ubuntu-latest
Expand All @@ -15,7 +19,7 @@ jobs:
- name: setup node
uses: actions/setup-node@v3
with:
node-version: 18
node-version: 20
- name: build
run: make deps-frontend frontend deps-backend
- name: Install playwright browsers
Expand Down

0 comments on commit 0ca1958

Please sign in to comment.