GetVersionsByPackageName witll throw ErrNotExist when no packages found

diana.strebkova@t-systems.com · wxiaoguang · commit 189c0ed190d7 · 2025-02-21T22:43:06.000+08:00
diff --git a/routers/api/packages/maven/maven.go b/routers/api/packages/maven/maven.go
@@ -90,12 +90,14 @@ func serveMavenMetadata(ctx *context.Context, params parameters) {
 	if errors.Is(err, util.ErrNotExist) {
 		pvs, err = packages_model.GetVersionsByPackageName(ctx, ctx.Package.Owner.ID, packages_model.TypeMaven, params.toInternalPackageNameLegacy())
 	}
-	if err != nil {
-		apiError(ctx, http.StatusInternalServerError, err)
+
+	if errors.Is(err, util.ErrNotExist) {
+		apiError(ctx, http.StatusNotFound, packages_model.ErrPackageNotExist)
 		return
 	}
-	if len(pvs) == 0 {
-		apiError(ctx, http.StatusNotFound, packages_model.ErrPackageNotExist)
+
+	if err != nil {
+		apiError(ctx, http.StatusInternalServerError, err)
 		return
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -90,12 +90,14 @@ func serveMavenMetadata(ctx *context.Context, params parameters) {`
`90`	`90`	`if errors.Is(err, util.ErrNotExist) {`
`91`	`91`	`pvs, err = packages_model.GetVersionsByPackageName(ctx, ctx.Package.Owner.ID, packages_model.TypeMaven, params.toInternalPackageNameLegacy())`
`92`	`92`	`}`
`93`		`- if err != nil {`
`94`		`- apiError(ctx, http.StatusInternalServerError, err)`
	`93`	`+`
	`94`	`+ if errors.Is(err, util.ErrNotExist) {`
	`95`	`+ apiError(ctx, http.StatusNotFound, packages_model.ErrPackageNotExist)`
`95`	`96`	`return`
`96`	`97`	`}`
`97`		`- if len(pvs) == 0 {`
`98`		`- apiError(ctx, http.StatusNotFound, packages_model.ErrPackageNotExist)`
	`98`	`+`
	`99`	`+ if err != nil {`
	`100`	`+ apiError(ctx, http.StatusInternalServerError, err)`
`99`	`101`	`return`
`100`	`102`	`}`
`101`	`103`