Skip to content

Commit 365bb77

Browse files
authored
Fix issues list page multiple selection update milestones (#24660)
Fix #24651
1 parent f6e029e commit 365bb77

File tree

1 file changed

+18
-5
lines changed

1 file changed

+18
-5
lines changed

templates/repo/issue/list.tmpl

+18-5
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,7 @@
241241
</div>
242242

243243
<!-- Milestone -->
244-
<div class="ui {{if not .Milestones}}disabled{{end}} dropdown jump item">
244+
<div class="ui {{if not (or .OpenMilestones .ClosedMilestones)}}disabled{{end}} dropdown jump item">
245245
<span class="text">
246246
{{.locale.Tr "repo.issues.action_milestone"}}
247247
{{svg "octicon-triangle-down" 14 "dropdown icon"}}
@@ -250,10 +250,23 @@
250250
<div class="item issue-action" data-element-id="0" data-url="{{$.Link}}/milestone">
251251
{{.locale.Tr "repo.issues.action_milestone_no_select"}}
252252
</div>
253-
{{range .Milestones}}
254-
<div class="item issue-action" data-element-id="{{.ID}}" data-url="{{$.RepoLink}}/issues/milestone">
255-
{{.Name}}
256-
</div>
253+
{{if .OpenMilestones}}
254+
<div class="divider"></div>
255+
<div class="header">{{.locale.Tr "repo.issues.filter_milestone_open"}}</div>
256+
{{range .OpenMilestones}}
257+
<div class="item issue-action" data-element-id="{{.ID}}" data-url="{{$.RepoLink}}/issues/milestone">
258+
{{.Name}}
259+
</div>
260+
{{end}}
261+
{{end}}
262+
{{if .ClosedMilestones}}
263+
<div class="divider"></div>
264+
<div class="header">{{.locale.Tr "repo.issues.filter_milestone_open"}}</div>
265+
{{range .ClosedMilestones}}
266+
<div class="item issue-action" data-element-id="{{.ID}}" data-url="{{$.RepoLink}}/issues/milestone">
267+
{{.Name}}
268+
</div>
269+
{{end}}
257270
{{end}}
258271
</div>
259272
</div>

0 commit comments

Comments
 (0)