Skip to content

Commit 503af4b

Browse files
GiteaBotsilverwind
andauthored
CSS color tweaks (#23828) (#23842)
Backport #23828 by @silverwind Change grey shades in arc-green to match the theme more: <img width="661" alt="Screenshot 2023-03-30 at 21 42 34" src="https://user-images.githubusercontent.com/115237/228957952-8e099e56-6923-4aa6-8ce9-3c1cd898b73e.png"> Adjusted grey shade in light theme: <img width="652" alt="image" src="https://user-images.githubusercontent.com/115237/228963876-3bde6181-8397-4dc2-be72-33982e6c7acb.png"> Increase contrast in arc-green, change background to slightly darker shade, change forgeground to slightly brighter colors: <img width="283" alt="Screenshot 2023-03-30 at 22 33 20" src="https://user-images.githubusercontent.com/115237/228957957-272c24a5-dd0b-427a-b6b7-e62836bdd73c.png"> Increase contrast of grey text in light theme as well by making them darker: <img width="273" alt="Screenshot 2023-03-30 at 22 33 35" src="https://user-images.githubusercontent.com/115237/228957959-283139c7-6fa7-4b68-9fdd-16c668ad1301.png"> Add color rule for border multiple select items: <img width="183" alt="Screenshot 2023-03-30 at 22 29 31" src="https://user-images.githubusercontent.com/115237/228957954-6b5a752d-bbb0-4519-ab35-d02c0804d955.png"> <img width="181" alt="Screenshot 2023-03-30 at 22 29 46" src="https://user-images.githubusercontent.com/115237/228957956-fca9790a-d6c9-4f31-8d1b-d183ab3ac669.png"> Added color rule for red `*` on required form fields: <img width="97" alt="image" src="https://user-images.githubusercontent.com/115237/228958760-517ad9ef-565d-4349-b734-9b559ab42429.png"> Co-authored-by: silverwind <me@silverwind.io>
1 parent 8b3dd7d commit 503af4b

File tree

3 files changed

+27
-14
lines changed

3 files changed

+27
-14
lines changed

web_src/css/base.css

+6-2
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,6 @@
7878
--color-purple: #a333c8;
7979
--color-pink: #e03997;
8080
--color-brown: #a5673f;
81-
--color-grey: #888888;
8281
--color-black: #1b1c1d;
8382
/* light variants - produced via Sass scale-color(color, $lightness: +25%) */
8483
--color-red-light: #e45e5e;
@@ -92,9 +91,10 @@
9291
--color-purple-light: #bb64d8;
9392
--color-pink-light: #e86bb1;
9493
--color-brown-light: #c58b66;
95-
--color-grey-light: #a6a6a6;
9694
--color-black-light: #525558;
9795
/* other colors */
96+
--color-grey: #707070;
97+
--color-grey-light: #838383;
9898
--color-gold: #a1882b;
9999
--color-white: #ffffff;
100100
--color-diff-removed-word-bg: #fdb8c0;
@@ -2665,6 +2665,10 @@ table th[data-sortt-desc] .svg {
26652665
border-radius: 0 0 var(--border-radius) var(--border-radius);
26662666
}
26672667

2668+
.ui.multiple.dropdown > .label {
2669+
box-shadow: 0 0 0 1px var(--color-secondary) inset;
2670+
}
2671+
26682672
.text-label {
26692673
display: inline-flex !important;
26702674
align-items: center !important;

web_src/css/form.css

+9
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,15 @@ textarea:focus,
9494
color: var(--color-text);
9595
}
9696

97+
.ui.form .required.fields:not(.grouped) > .field > label::after,
98+
.ui.form .required.fields.grouped > label::after,
99+
.ui.form .required.field > label::after,
100+
.ui.form .required.fields:not(.grouped) > .field > .checkbox::after,
101+
.ui.form .required.field > .checkbox::after,
102+
.ui.form label.required::after {
103+
color: var(--color-red);
104+
}
105+
97106
.ui.input,
98107
.ui.checkbox input:focus ~ label::after,
99108
.ui.checkbox input:checked ~ label::after,

web_src/css/themes/theme-arc-green.css

+12-12
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,7 @@
6868
--color-purple: #b259d0;
6969
--color-pink: #d22e8b;
7070
--color-brown: #a47252;
71-
--color-grey: #9ea2aa;
72-
--color-black: #1e222e;
71+
--color-black: #2e323e;
7372
/* light variants - produced via Sass scale-color(color, $lightness: -10%) */
7473
--color-red-light: #c23636;
7574
--color-orange-light: #b84f0b;
@@ -82,9 +81,10 @@
8281
--color-purple-light: #a742c9;
8382
--color-pink-light: #be297d;
8483
--color-brown-light: #94674a;
85-
--color-grey-light: #8d919b;
86-
--color-black-light: #1b1f29;
84+
--color-black-light: #292d38;
8785
/* other colors */
86+
--color-grey: #505665;
87+
--color-grey-light: #a1a6b7;
8888
--color-gold: #b1983b;
8989
--color-white: #ffffff;
9090
--color-diff-removed-word-bg: #6f3333;
@@ -124,19 +124,19 @@
124124
--color-orange-badge-hover-bg: #f2711c4d;
125125
--color-git: #f05133;
126126
/* target-based colors */
127-
--color-body: #383c4a;
127+
--color-body: #373b47;
128128
--color-box-header: #404652;
129129
--color-box-body: #2a2e3a;
130130
--color-box-body-highlight: #353945;
131131
--color-text-dark: #dbe0ea;
132-
--color-text: #bbc0ca;
133-
--color-text-light: #a6aab5;
134-
--color-text-light-1: #979ba6;
135-
--color-text-light-2: #8a8e99;
136-
--color-text-light-3: #707687;
132+
--color-text: #cbd0da;
133+
--color-text-light: #bbbfca;
134+
--color-text-light-1: #aaafb9;
135+
--color-text-light-2: #9a9ea9;
136+
--color-text-light-3: #8a8e99;
137137
--color-footer: #2e323e;
138138
--color-timeline: #4c525e;
139-
--color-input-text: #d5dbe6;
139+
--color-input-text: #dfe3ec;
140140
--color-input-background: #232933;
141141
--color-input-toggle-background: #454a57;
142142
--color-input-border: #454a57;
@@ -159,7 +159,7 @@
159159
--color-secondary-bg: #2a2e3a;
160160
--color-text-focus: #fff;
161161
--color-expand-button: #3c404d;
162-
--color-placeholder-text: #6a737d;
162+
--color-placeholder-text: #8a8e99;
163163
--color-editor-line-highlight: var(--color-primary-light-5);
164164
--color-project-board-bg: var(--color-secondary-light-2);
165165
--color-caret: var(--color-text); /* should ideally be --color-text-dark, see #15651 */

0 commit comments

Comments
 (0)