Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 56f222d

Browse files
alrslunny
andauthoredJul 6, 2020
models: break out of loops (#12159)
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
1 parent ae2916c commit 56f222d

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed
 

‎models/repo_sign.go

+6-3
Original file line numberDiff line numberDiff line change
@@ -103,12 +103,13 @@ func SignInitialCommit(repoPath string, u *User) (bool, string, error) {
103103
return false, "", &ErrWontSign{noKey}
104104
}
105105

106+
Loop:
106107
for _, rule := range rules {
107108
switch rule {
108109
case never:
109110
return false, "", &ErrWontSign{never}
110111
case always:
111-
break
112+
break Loop
112113
case pubkey:
113114
keys, err := ListGPGKeys(u.ID, ListOptions{})
114115
if err != nil {
@@ -138,12 +139,13 @@ func (repo *Repository) SignWikiCommit(u *User) (bool, string, error) {
138139
return false, "", &ErrWontSign{noKey}
139140
}
140141

142+
Loop:
141143
for _, rule := range rules {
142144
switch rule {
143145
case never:
144146
return false, "", &ErrWontSign{never}
145147
case always:
146-
break
148+
break Loop
147149
case pubkey:
148150
keys, err := ListGPGKeys(u.ID, ListOptions{})
149151
if err != nil {
@@ -190,12 +192,13 @@ func (repo *Repository) SignCRUDAction(u *User, tmpBasePath, parentCommit string
190192
return false, "", &ErrWontSign{noKey}
191193
}
192194

195+
Loop:
193196
for _, rule := range rules {
194197
switch rule {
195198
case never:
196199
return false, "", &ErrWontSign{never}
197200
case always:
198-
break
201+
break Loop
199202
case pubkey:
200203
keys, err := ListGPGKeys(u.ID, ListOptions{})
201204
if err != nil {

0 commit comments

Comments
 (0)
Please sign in to comment.