Skip to content

Commit

Permalink
fix bug
Browse files Browse the repository at this point in the history
  • Loading branch information
a1012112796 committed Nov 22, 2020
1 parent 26a5999 commit 786f823
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions routers/api/v1/repo/pull_review.go
Original file line number Diff line number Diff line change
Expand Up @@ -794,7 +794,7 @@ func DismissPullReview(ctx *context.APIContext, opts api.DismissPullReviewOption
// "$ref": "#/responses/forbidden"
// "422":
// "$ref": "#/responses/validationError"
disMissReview(ctx, true)
disMissReview(ctx, opts.Message, true)
}

// UnDismissPullReview cancel to dismiss a review for a pull request
Expand Down Expand Up @@ -834,10 +834,10 @@ func UnDismissPullReview(ctx *context.APIContext) {
// "$ref": "#/responses/forbidden"
// "422":
// "$ref": "#/responses/validationError"
disMissReview(ctx, false)
disMissReview(ctx, "", false)
}

func disMissReview(ctx *context.APIContext, isDismiss bool) {
func disMissReview(ctx *context.APIContext, msg string, isDismiss bool) {
if !ctx.Repo.IsAdmin() {
ctx.Error(http.StatusForbidden, "", "Must be repo admin")
return
Expand All @@ -857,7 +857,7 @@ func disMissReview(ctx *context.APIContext, isDismiss bool) {
return
}

_, err := pull_service.DismissReview(review.ID, opts.Message, ctx.User, isDismiss)
_, err := pull_service.DismissReview(review.ID, msg, ctx.User, isDismiss)
if err != nil {
ctx.Error(http.StatusInternalServerError, "pull_service.DismissReview", err)
return
Expand Down

0 comments on commit 786f823

Please sign in to comment.