Skip to content

Commit 786f823

Browse files
committed
fix bug
1 parent 26a5999 commit 786f823

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

routers/api/v1/repo/pull_review.go

+4-4
Original file line numberDiff line numberDiff line change
@@ -794,7 +794,7 @@ func DismissPullReview(ctx *context.APIContext, opts api.DismissPullReviewOption
794794
// "$ref": "#/responses/forbidden"
795795
// "422":
796796
// "$ref": "#/responses/validationError"
797-
disMissReview(ctx, true)
797+
disMissReview(ctx, opts.Message, true)
798798
}
799799

800800
// UnDismissPullReview cancel to dismiss a review for a pull request
@@ -834,10 +834,10 @@ func UnDismissPullReview(ctx *context.APIContext) {
834834
// "$ref": "#/responses/forbidden"
835835
// "422":
836836
// "$ref": "#/responses/validationError"
837-
disMissReview(ctx, false)
837+
disMissReview(ctx, "", false)
838838
}
839839

840-
func disMissReview(ctx *context.APIContext, isDismiss bool) {
840+
func disMissReview(ctx *context.APIContext, msg string, isDismiss bool) {
841841
if !ctx.Repo.IsAdmin() {
842842
ctx.Error(http.StatusForbidden, "", "Must be repo admin")
843843
return
@@ -857,7 +857,7 @@ func disMissReview(ctx *context.APIContext, isDismiss bool) {
857857
return
858858
}
859859

860-
_, err := pull_service.DismissReview(review.ID, opts.Message, ctx.User, isDismiss)
860+
_, err := pull_service.DismissReview(review.ID, msg, ctx.User, isDismiss)
861861
if err != nil {
862862
ctx.Error(http.StatusInternalServerError, "pull_service.DismissReview", err)
863863
return

0 commit comments

Comments
 (0)