Skip to content

Commit 8f72201

Browse files
GiteaBotlunny
andauthored
Fix issues list page multiple selection update milestones (#24660) (#24663)
Backport #24660 by @lunny Fix #24651 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
1 parent cb7ba89 commit 8f72201

File tree

1 file changed

+18
-5
lines changed

1 file changed

+18
-5
lines changed

templates/repo/issue/list.tmpl

+18-5
Original file line numberDiff line numberDiff line change
@@ -257,7 +257,7 @@
257257
</div>
258258

259259
<!-- Milestone -->
260-
<div class="ui {{if not .Milestones}}disabled{{end}} dropdown jump item">
260+
<div class="ui {{if not (or .OpenMilestones .ClosedMilestones)}}disabled{{end}} dropdown jump item">
261261
<span class="text">
262262
{{.locale.Tr "repo.issues.action_milestone"}}
263263
{{svg "octicon-triangle-down" 14 "dropdown icon"}}
@@ -266,10 +266,23 @@
266266
<div class="item issue-action" data-element-id="0" data-url="{{$.Link}}/milestone">
267267
{{.locale.Tr "repo.issues.action_milestone_no_select"}}
268268
</div>
269-
{{range .Milestones}}
270-
<div class="item issue-action" data-element-id="{{.ID}}" data-url="{{$.RepoLink}}/issues/milestone">
271-
{{.Name}}
272-
</div>
269+
{{if .OpenMilestones}}
270+
<div class="divider"></div>
271+
<div class="header">{{.locale.Tr "repo.issues.filter_milestone_open"}}</div>
272+
{{range .OpenMilestones}}
273+
<div class="item issue-action" data-element-id="{{.ID}}" data-url="{{$.RepoLink}}/issues/milestone">
274+
{{.Name}}
275+
</div>
276+
{{end}}
277+
{{end}}
278+
{{if .ClosedMilestones}}
279+
<div class="divider"></div>
280+
<div class="header">{{.locale.Tr "repo.issues.filter_milestone_open"}}</div>
281+
{{range .ClosedMilestones}}
282+
<div class="item issue-action" data-element-id="{{.ID}}" data-url="{{$.RepoLink}}/issues/milestone">
283+
{{.Name}}
284+
</div>
285+
{{end}}
273286
{{end}}
274287
</div>
275288
</div>

0 commit comments

Comments
 (0)