fix completeness calculate

go-gitea · Sep 29, 2019 · 912d305 · 912d305
1 parent 067826a
commit 912d305
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/models/issue_milestone.go b/models/issue_milestone.go
@@ -319,7 +319,7 @@ func updateMilestoneTotalNum(e Engine, milestoneID int64) (err error) {
 		return
 	}
 
-	_, err = e.Exec("UPDATE `milestone` SET completeness=100*num_closed_issues/(num_issues+1-sign(num_issues)) WHERE id=?",
+	_, err = e.Exec("UPDATE `milestone` SET completeness=100*num_closed_issues/(num_issues+1-(CASE WHEN num_issues > 0 THEN 1 ELSE 0 END)) WHERE id=?",
 		milestoneID,
 	)
 
@@ -335,7 +335,7 @@ func updateMilestoneClosedNum(e Engine, milestoneID int64) (err error) {
 		return
 	}
 
-	_, err = e.Exec("UPDATE `milestone` SET completeness=100*num_closed_issues/(num_issues+1-sign(num_issues)) WHERE id=?",
+	_, err = e.Exec("UPDATE `milestone` SET completeness=100*num_closed_issues/(num_issues+1-(CASE WHEN num_issues > 0 THEN 1 ELSE 0 END)) WHERE id=?",
 		milestoneID,
 	)
 	return