Skip to content

Commit 95e2e3a

Browse files
authored
Change valid_until translation to valid_until_date and include placeholder for the date (#24563)
- Similar to #24550 - Similar to #24562 The correct thing to do is to translate the entire phrase into a single string. The previous translation assumed all languages have a space between the "valid until" and the date (and that "valid until" comes before the date). Signed-off-by: Yarden Shoham <git@yardenshoham.com>
1 parent ef92459 commit 95e2e3a

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

options/locale/locale_en-US.ini

+1-1
Original file line numberDiff line numberDiff line change
@@ -755,7 +755,7 @@ ssh_key_deletion_success = The SSH key has been removed.
755755
gpg_key_deletion_success = The GPG key has been removed.
756756
ssh_principal_deletion_success = The principal has been removed.
757757
add_on = Added on
758-
valid_until = Valid until
758+
valid_until_date = Valid until %s
759759
valid_forever = Valid forever
760760
last_used = Last used on
761761
no_activity = No recent activity

templates/user/settings/keys_gpg.tmpl

+1-1
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@
7070
<div class="activity meta">
7171
<i>{{$.locale.Tr "settings.add_on"}} <span>{{DateTime "short" .AddedUnix}}</span></i>
7272
-
73-
<i>{{if not .ExpiredUnix.IsZero}}{{$.locale.Tr "settings.valid_until"}} <span>{{DateTime "short" .ExpiredUnix}}</span>{{else}}{{$.locale.Tr "settings.valid_forever"}}{{end}}</i>
73+
<i>{{if not .ExpiredUnix.IsZero}}{{$.locale.Tr "settings.valid_until_date" (DateTime "short" .ExpiredUnix) | Safe}}{{else}}{{$.locale.Tr "settings.valid_forever"}}{{end}}</i>
7474
</div>
7575
</div>
7676
</div>

0 commit comments

Comments
 (0)