Skip to content

Commit a7212e7

Browse files
committed
Change Close to either Close issue or Close pull request
Signed-off-by: Yarden Shoham <hrsi88@gmail.com>
1 parent 6aef9e0 commit a7212e7

File tree

2 files changed

+14
-1
lines changed

2 files changed

+14
-1
lines changed

options/locale/locale_en-US.ini

+2-1
Original file line numberDiff line numberDiff line change
@@ -1369,7 +1369,7 @@ issues.context.reference_issue = Reference in New Issue
13691369
issues.context.edit = Edit
13701370
issues.context.delete = Delete
13711371
issues.no_content = There is no content yet.
1372-
issues.close_issue = Close
1372+
issues.close_issue = Close issue
13731373
issues.pull_merged_at = `merged commit <a class="ui sha" href="%[1]s"><code>%[2]s</code></a> into <b>%[3]s</b> %[4]s`
13741374
issues.manually_pull_merged_at = `merged commit <a class="ui sha" href="%[1]s"><code>%[2]s</code></a> into <b>%[3]s</b> manually %[4]s`
13751375
issues.close_comment_issue = Comment and Close
@@ -1654,6 +1654,7 @@ pulls.update_branch_rebase = Update branch by rebase
16541654
pulls.update_branch_success = Branch update was successful
16551655
pulls.update_not_allowed = You are not allowed to update branch
16561656
pulls.outdated_with_base_branch = This branch is out-of-date with the base branch
1657+
pulls.close = Close pull request
16571658
pulls.closed_at = `closed this pull request <a id="%[1]s" href="#%[1]s">%[2]s</a>`
16581659
pulls.reopened_at = `reopened this pull request <a id="%[1]s" href="#%[1]s">%[2]s</a>`
16591660
pulls.merge_instruction_hint = `You can also view <a class="show-instruction">command line instructions</a>.`

templates/repo/issue/view_content.tmpl

+12
Original file line numberDiff line numberDiff line change
@@ -116,9 +116,15 @@
116116
{{.locale.Tr "repo.issues.reopen_issue"}}
117117
</button>
118118
{{else}}
119+
{{if .Issue.IsPull}}
120+
<button id="status-button" class="ui red basic button" tabindex="6" data-status="{{.locale.Tr "repo.pulls.close"}}" data-status-and-comment="{{.locale.Tr "repo.issues.close_comment_issue"}}" data-status-val="close">
121+
{{.locale.Tr "repo.pulls.close"}}
122+
</button>
123+
{{else}}
119124
<button id="status-button" class="ui red basic button" tabindex="6" data-status="{{.locale.Tr "repo.issues.close_issue"}}" data-status-and-comment="{{.locale.Tr "repo.issues.close_comment_issue"}}" data-status-val="close">
120125
{{.locale.Tr "repo.issues.close_issue"}}
121126
</button>
127+
{{end}}
122128
{{end}}
123129
{{end}}
124130
<button class="ui green button loading-button" tabindex="5">
@@ -167,9 +173,15 @@
167173
{{.locale.Tr "repo.issues.reopen_issue"}}
168174
</button>
169175
{{else}}
176+
{{if .Issue.IsPull}}
177+
<button id="status-button" class="ui red basic button" tabindex="6" data-status="{{.locale.Tr "repo.pulls.close"}}" data-status-and-comment="{{.locale.Tr "repo.issues.close_comment_issue"}}" data-status-val="close">
178+
{{.locale.Tr "repo.pulls.close"}}
179+
</button>
180+
{{else}}
170181
<button id="status-button" class="ui red basic button" tabindex="6" data-status="{{.locale.Tr "repo.issues.close_issue"}}" data-status-and-comment="{{.locale.Tr "repo.issues.close_comment_issue"}}" data-status-val="close">
171182
{{.locale.Tr "repo.issues.close_issue"}}
172183
</button>
184+
{{end}}
173185
{{end}}
174186
{{end}}
175187
<button class="ui green button loading-button" tabindex="5">

0 commit comments

Comments
 (0)