Add missed close in ServeBlobLFS (#8527) (#8543)

zeripath · lunny · commit c1152b15fe98 · 2019-10-17T00:05:23.000+08:00
diff --git a/routers/repo/download.go b/routers/repo/download.go
@@ -84,6 +84,11 @@ func ServeBlobOrLFS(ctx *context.Context, blob *git.Blob) error {
 		if err != nil {
 			return err
 		}
+		defer func() {
+			if err = lfsDataRc.Close(); err != nil {
+				log.Error("ServeBlobOrLFS: Close: %v", err)
+			}
+		}()
 		return ServeData(ctx, ctx.Repo.TreePath, lfsDataRc)
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -84,6 +84,11 @@ func ServeBlobOrLFS(ctx context.Context, blob git.Blob) error {`
`84`	`84`	`if err != nil {`
`85`	`85`	`return err`
`86`	`86`	`}`
	`87`	`+ defer func() {`
	`88`	`+ if err = lfsDataRc.Close(); err != nil {`
	`89`	`+ log.Error("ServeBlobOrLFS: Close: %v", err)`
	`90`	`+ }`
	`91`	`+ }()`
`87`	`92`	`return ServeData(ctx, ctx.Repo.TreePath, lfsDataRc)`
`88`	`93`	`}`
`89`	`94`