Skip to content

Commit eb793c3

Browse files
lunnyKN4CK3R
andauthored
Fix bug on user setting (#22539)
Fix #22537 Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
1 parent a1fcb1c commit eb793c3

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

Diff for: models/user/setting.go

+10-4
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import (
1010

1111
"code.gitea.io/gitea/models/db"
1212
"code.gitea.io/gitea/modules/cache"
13+
setting_module "code.gitea.io/gitea/modules/setting"
1314

1415
"xorm.io/builder"
1516
)
@@ -154,11 +155,16 @@ func SetUserSetting(userID int64, key, value string) error {
154155
return err
155156
}
156157

157-
_, err := cache.GetString(genSettingCacheKey(userID, key), func() (string, error) {
158-
return value, upsertUserSettingValue(userID, key, value)
159-
})
158+
if err := upsertUserSettingValue(userID, key, value); err != nil {
159+
return err
160+
}
160161

161-
return err
162+
cc := cache.GetCache()
163+
if cc != nil {
164+
return cc.Put(genSettingCacheKey(userID, key), value, setting_module.CacheService.TTLSeconds())
165+
}
166+
167+
return nil
162168
}
163169

164170
func upsertUserSettingValue(userID int64, key, value string) error {

0 commit comments

Comments
 (0)