Fix only text/* being viewable in web UI (#34374) (#34378)

GiteaBot · bytedream · web-flow · commit ed527b664dfa · 2025-05-06T05:18:12.000Z
Backport #34374 by @bytedream Regression from #34356, files like SVGs should be editable too (#34356 (comment)). Co-authored-by: bytedream <bytedream@protonmail.com>
diff --git a/routers/web/repo/editor.go b/routers/web/repo/editor.go
@@ -165,7 +165,7 @@ func editFile(ctx *context.Context, isNewFile bool) {
 		ctx.Data["FileSize"] = blob.Size()
 
 		// Only some file types are editable online as text.
-		if !fInfo.isTextFile || fInfo.isLFSFile {
+		if !fInfo.st.IsRepresentableAsText() || fInfo.isLFSFile {
 			ctx.NotFound(nil)
 			return
 		}

Original file line number	Diff line number	Diff line change
`@@ -165,7 +165,7 @@ func editFile(ctx *context.Context, isNewFile bool) {`
`165`	`165`	`ctx.Data["FileSize"] = blob.Size()`
`166`	`166`
`167`	`167`	`// Only some file types are editable online as text.`
`168`		`- if !fInfo.isTextFile \|\| fInfo.isLFSFile {`
	`168`	`+ if !fInfo.st.IsRepresentableAsText() \|\| fInfo.isLFSFile {`
`169`	`169`	`ctx.NotFound(nil)`
`170`	`170`	`return`
`171`	`171`	`}`