DefaultRepoUnits doesn't seem to be loaded from app.ini

[sadaszewski]

• Gitea version (or commit ref): 1.11.4
• Git version:
• Operating system: FreeBSD
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant
• Log gist:

Description

DEFAULT_REPO_UNITS setting seems to have no effect. A glance at:

https://github.com/go-gitea/gitea/blob/c8d7ae1ee33e31ed15632a26c74ba9a3ea115043/modules/setting/repository.go

reveals that it isn't even loaded from app.ini as far as I can tell. Please advise.

Screenshots

[sadaszewski]

• Typo, Gitea Release 1.11.4

[guillep2k]

Maybe you're looking for this?

gitea/modules/setting/repository.go

Line 213 in c8d7ae1

if err = Cfg.Section("repository").MapTo(&Repository); err != nil {

Cfg.Section() will automagically fill in the values from app.ini.

If you make any changes to app.ini, make sure you restart the instance. If you're having problems, maybe checking in in our Discord chat first would help.

[sadaszewski]

Hi guillep2k, thank you for your comment. Agreed, it seems as it is being loaded. Nevertheless it doesn't work, i.e. always all units are added to new repositories. The settings in app.ini seem to be correct specifying:

[repository]
DEFAULT_REPO_UNITS=repo.code

and the app has been restarted multiple times. Nevertheless, all new repositories are created with all units activated. I took another look and in:

gitea/models/repo.go

Line 1054 in 4be7cf0

var units = make([]RepoUnit, 0, len(DefaultRepoUnits))

one can see that DefaultRepoUnits are referenced but I am afraid this is not the DefaultRepoUnits from:

gitea/modules/setting/repository.go

Line 41 in c8d7ae1

DefaultRepoUnits []string

I believe those are rather the array of all repo units from here:

gitea/models/unit.go

Line 74 in 3c07d03

DefaultRepoUnits = []UnitType{

Could you please confirm and if so - is somebody working on a fix? Thank you in advance. BR, -- Stanislaw

[zeripath]

This feature was added in #8788 which is on the 1.12 milestone. It is therefore not available to 1.11.4.