-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
words
and lines
are not localized
#11369
Comments
The english ones were updated in 28e5e7f, I guess Crowdin has not caught up yet (I don't really know how it works exactly)? |
@silverwind ah, so should I rather use Crowdin instead of the PR? |
PR should be fine I guess. Maybe someone with a better understanding of Crowdin can comment how a case of updated english works. Given that you're seeing english, I think it invalidated all previous translations. |
@silverwind ah so @a1012112796 just wrote that I should rather use crowdin. Also I wasn't able to find 'lines' and 'words'… |
Doing it on crowdin is certainly better and faster as translations don't require review. |
Okay, the first point is already translated (I update the issue accordingly) but which are the keys for |
words
and lines
not localized?
words
and lines
not localized?words
and lines
are not localized
This is (yet another) SimpleMDE/Codemirror problem |
@zeripath so is there already an open issue for it? 🤔 |
I assume this is hardcoded in SimpleMDE, but fix will come with #10729. |
This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions. |
Fixed with #23876 which removes these from the default editor. |
1.12.0+dev-292-g742e26f5a
Yes, this is actually how I stumbled over it. I have some test repositories because of some previous bug reports and someone created a test issue — which I closed. Suddenly I saw that the activated locale was in german. So everything was in german except "lines" and "words".
Screenshots
The text was updated successfully, but these errors were encountered: