Skip to content

Two panel view in editor mode is gone for markdown files #11972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 of 7 tasks
tomposmiko opened this issue Jun 19, 2020 · 20 comments
Open
2 of 7 tasks

Two panel view in editor mode is gone for markdown files #11972

tomposmiko opened this issue Jun 19, 2020 · 20 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/ui Change the appearance of the Gitea UI

Comments

@tomposmiko
Copy link

  • Gitea version (or commit ref):
  • Git version: 1.12.0
  • Operating system: Linux Ubuntu 18.04
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

On try.gitea.io:
https://try.gitea.io/tompos/aaa/_edit/master/a.md

The two panel editing option is gone. There is no more way to edit a markdown file and see the rendered changes in real time.
...

Screenshots

@silverwind
Copy link
Member

silverwind commented Jun 20, 2020

I wasn't aware of the existance of such a mode but this is intended because markdown files now edit like any other file and it was done in foresight for the SimpleMDE/CodeMirror removal. It could of course be introduced again.

@tomposmiko
Copy link
Author

tomposmiko commented Jun 22, 2020

Yes, bring it back please.
It was an extremely nice editor, actually better the most other editors.

@tomposmiko
Copy link
Author

I just realized, not only the two panel mode, but the formatting toolbar is also gone.
This is very bad. The user experience is now way worse than before. Why was the change actually? What problem required this solution?

@tomposmiko
Copy link
Author

Also headings are hard to be distinguished, the font sizes are very close to each other.

@silverwind
Copy link
Member

We want to remove the bloated, buggy and unmaintained markdown editor, see #10729. Generally I'm not sure if we want to treat editing markdown files differently, GitHub also doesn't.

@tomposmiko
Copy link
Author

Yes, GitHub also does not provide realtime preview for the .md files in the editor.
So Gitea's editor was way better so far. It's a huge drawback now and it would be a huge improvement and delighter to bring it back.

@lunny
Copy link
Member

lunny commented Jul 7, 2020

@tomposmiko This changed because we want to edit codes on the web. Maybe we should have a markdown priview plugin on monaco editor.

@lafriks
Copy link
Member

lafriks commented Jul 7, 2020

And adding toolbar back would also be probably doable

@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Jul 8, 2020
@silverwind
Copy link
Member

silverwind commented Jul 8, 2020

I have a hard time understanding how this has worked before (I've never seen it). Was it a side-by-side editor and preview? I guess if the screen is of sufficient width, we could just put the content of the preview tab at the side of the editor instead of its own tab.

@mrsdizzie
Copy link
Member

you could still see on the wiki editor since it is still SimpleMDE -- just edit a page and click the 2nd to last button 'toggle side by side'

@silverwind
Copy link
Member

I see, so it's fullscreening the editor and preview. Certainly possible but I think we should first replace SimpleMDE, add that new editing toolbar and then make a shared abstraction over both textarea-based and monaco-based editor that adds features like this.

@tomposmiko
Copy link
Author

I don't personally miss the full screen mode, but the real time visualization.
Thanks guys!

I also have concerns about the style (font size?).
Should I report it in a different issue?

@stale
Copy link

stale bot commented Sep 11, 2020

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale stale bot added the issue/stale label Sep 11, 2020
@tomposmiko
Copy link
Author

Well, can we expected any change about this issue?
If not, we can close it.
If yes, that would be awesome!

@stale stale bot removed the issue/stale label Sep 15, 2020
@luwol03
Copy link

luwol03 commented Sep 15, 2020

I will like these feature. Everyone who has the same opinion can react with 👍 emoji.

@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Sep 16, 2020
@kevintruong
Copy link

I would love to have markdown editor when I edit a markdown file.
Currently, the default editor is apply for markdown file.
Is that possible for this one

@73DX
Copy link

73DX commented Mar 4, 2021

Please turn this feature back on. The Markdown tool bar would be a great success to be used in Markdown documents using the Github UI.
Contributors that way do not need to install additional software of use other sites to do it.

@davewat
Copy link

davewat commented Apr 6, 2021

We are stuck on version < 1.12.0 until the ability to edit Markdown (with editor toolbar/preview) is re-enabled.

Our use case - we have a large number of users that provide simple edits to MD documentation in a repo. They are not technical, and cannot handle MD. The toolbar/ preview capability allows them to edit the documentation.

@silverwind
Copy link
Member

with editor toolbar/preview

The Markdown preview tab is still there, there's just no side-by-side mode currently.

As for toolbar, I'm thinking about integrating https://github.com/github/markdown-toolbar-element but it may not be easy because the module expects a textarea to work with, so some hackery will probably be required to make it work with monaco.

@Raytle
Copy link

Raytle commented Dec 29, 2024

I would like side-by-side mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

No branches or pull requests

10 participants