-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API] Get/Set User settings #13807
Comments
plan to remove theme from the database and make it a client-side only settings, so probably remove that one. Edit: See #13809 for further info on that. |
@silverwind So that user would not save his theme on settings? |
Why would not save selected theme in settings? If I use multiple devices that would require for me switching for every new device. Also for my development browser I use setting that deletes all local storage etc when I exit browser, that would require me changing theme every time :( |
I think browser storage is a nice option but I would still like to store it into DB as default falue for new browsers (cleared browsers) ... |
Yeah I guess on second thought, it might be inconvenient to some. Not sure how else to handle the case of logged out user theme. I guess one approach could be localStorage synced with the DB but any kind of localStorage use brings the issue that it can't cleanly be applied during page load, maybe it needs to go into the cookie after all. |
add new endpoint to set/get user settings:
selected themeThe text was updated successfully, but these errors were encountered: