Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] Get/Set User settings #13807

Closed
6543 opened this issue Dec 3, 2020 · 5 comments · Fixed by #16169
Closed

[API] Get/Set User settings #13807

6543 opened this issue Dec 3, 2020 · 5 comments · Fixed by #16169
Labels
modifies/api This PR adds API routes or modifies them type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@6543
Copy link
Member

6543 commented Dec 3, 2020

add new endpoint to set/get user settings:

  • Location
  • Language
  • Biography
  • Privacy settings (hide activity)
  • selected theme
@6543 6543 added type/proposal The new feature has not been accepted yet but needs to be discussed first. modifies/api This PR adds API routes or modifies them labels Dec 3, 2020
@silverwind
Copy link
Member

silverwind commented Dec 3, 2020

plan to remove theme from the database and make it a client-side only settings, so probably remove that one.

Edit: See #13809 for further info on that.

@lunny
Copy link
Member

lunny commented Dec 3, 2020

@silverwind So that user would not save his theme on settings?

@lafriks
Copy link
Member

lafriks commented Dec 3, 2020

Why would not save selected theme in settings? If I use multiple devices that would require for me switching for every new device. Also for my development browser I use setting that deletes all local storage etc when I exit browser, that would require me changing theme every time :(

@6543
Copy link
Member Author

6543 commented Dec 3, 2020

I think browser storage is a nice option but I would still like to store it into DB as default falue for new browsers (cleared browsers) ...

@silverwind
Copy link
Member

Yeah I guess on second thought, it might be inconvenient to some. Not sure how else to handle the case of logged out user theme. I guess one approach could be localStorage synced with the DB but any kind of localStorage use brings the issue that it can't cleanly be applied during page load, maybe it needs to go into the cookie after all.

@6543 6543 mentioned this issue May 7, 2021
12 tasks
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
modifies/api This PR adds API routes or modifies them type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants