Skip to content

[Bug] markdown link formater cant pars issue-url including comment-link #13842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
6543 opened this issue Dec 4, 2020 · 5 comments
Closed

[Bug] markdown link formater cant pars issue-url including comment-link #13842

6543 opened this issue Dec 4, 2020 · 5 comments
Labels

Comments

@6543
Copy link
Member

6543 commented Dec 4, 2020

Copy from https://codeberg.org/Codeberg/Community/issues/212

I just commented including this code:

and https://codeberg.org/Codeberg/Community/issues/140#issuecomment-49756 is now
-> and #140 now

so both the issue is not linked and the word after the URL is removed.

Inserting a second space after the url like so works:
and https://codeberg.org/Codeberg/Community/issues/140#issuecomment-49756 is now
-> and [#140](https://codeberg.org/Codeberg/Community/issues/140#issuecomment-49756) now


@6543 6543 added the type/bug label Dec 4, 2020
@noerw
Copy link
Member

noerw commented Sep 25, 2021

In 1.16.0+dev-248-g45ebcb0d1 a new regression exists (not present in 1.15 as far as i can tell):

For a URL like https://gitea.com/gitea/tea/pulls/410#issue-97552 a reference is correctly detected, but the URL is empty

image

@fnetX
Copy link
Contributor

fnetX commented Nov 20, 2021

The original issue seems to be fixed in 1.15, does the regression still exist?

@lunny
Copy link
Member

lunny commented Nov 22, 2021

@fnetX I think no. It's reported in v1.14. Let's close and feel free to reopen it if it's not resolved.

@lunny lunny closed this as completed Nov 22, 2021
@wxiaoguang
Copy link
Contributor

I remember that I fixed a markdown bug:

Are they related?

@fnetX
Copy link
Contributor

fnetX commented Nov 22, 2021

Yeah, #17394 is a dupe.

@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants