Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support adding GPG signing sub-key #14036

Closed
etanot opened this issue Dec 17, 2020 · 2 comments · Fixed by #14054
Closed

Support adding GPG signing sub-key #14036

etanot opened this issue Dec 17, 2020 · 2 comments · Fixed by #14054
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Milestone
1.15.0

Comments

@etanot
Copy link

etanot commented Dec 17, 2020

Type : Feature request

Description

As @a1012112796 has mentioned in #14009 (comment) "Now gitea only allow add public gpg keys bounded with the user's email", it would be nice if Gitea also support adding GPG sub-key, just like mention in issue #14009.
@a1012112796 a1012112796 added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Dec 17, 2020
@quhsi
Copy link

quhsi commented Jan 2, 2021

Currently, the email address cannot be kept private when using the PGP key feature. So this issue is more a bugfix than a feature.

@zeripath zeripath mentioned this issue Jan 2, 2021
Merged
@zeripath
Copy link
Contributor

zeripath commented Mar 2, 2021

#14054 was an attempt at fixing this issue - however, due to the lack of real life testing of this feature I've had to move it to the 1.15 milestone. Hopefully we'll merge after the merge window for 1.14 is closed.

If you really want this feature in 1.14 you will need to download and test this PR to ensure that it does what you want.

@zeripath zeripath added this to the 1.15.0 milestone Mar 2, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
1.15.0
Development

Successfully merging a pull request may close this issue.

GPG Key Ownership verification with Signed Token zeripath/gitea
4 participants
@zeripath @a1012112796 @etanot @quhsi