-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a character count or visible warning to repo descriptions #14251
Comments
While a UI would be nice, I'm curious why there is a limit at all. Is there a reason that this field is limited, or why the count is so low? I was able to remove this limit in a test build with no ill effects for SQLite3. I don't think any of the other DB types would care either. |
@kins-dev Agreed since there are cases where repo descriptions slightly longer than 255 are useful. In models/repo.go, repo description is set to TEXT, so the limit seems to be code-only. Could this limit be made a config parameter? The API descriptions could be more clear as well since they don't reference the char limit:
|
I removed all the limits from my test instance and it has been great. Given Jenkins pulls the repo description over automatically, (pipelines based on an organization) it gives me one version of the truth over multiple systems. I don't mind if this is configurable as long as no limit is an option. |
Just reported on Codeberg I just confirmed on try.gitea.io this also affects other input boxes (e.g. name), so an improvement should take care of all the input boxes there. Also, I noticed that spellcheck is disabled, does anyone know why this is explicitly set? |
Does anyone know a place in the Gitea Codebase where such a limit is already in place so that this could be copied / adapted? I just tried to adapt the checker on the repo tag code, but didn't get it to work. I'm also not really a frontend guy, but if pointed to some good resources I might be able to pick this up. |
Searching the Repository for MaxSize reveals that there's a handful of cases. Are we planning to replace the UI with JS validation for all these cases, or just the repository setting related UI? |
|
Description
When entering a description for a repository a user may not know of the 255 character limit until after attempting to save their description. If a description exceeds 255 characters it is cleared when the user attempts to save. A character count should be added (or a visible warning of the limit) to the web interface to avoid having users retype descriptions if they forget or do not know of this limit. Potentially for long descriptions the warning could advise users to put information in the repo README instead.
Screenshots
Example of proposed change on Imgur: https://imgur.com/a/y5NcnGS
The text was updated successfully, but these errors were encountered: