-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Add code suggestion for PR review comments #14765
Comments
I think this issue is duplicate of #9388. |
Well, partially. As @6543 pointed out in the issue description, it could be applied to this issue. |
This comment was marked as off-topic.
This comment was marked as off-topic.
What is the progress on this one? |
I see no need for this. Language can just be determined from the currently edited file for syntax highlighting purpose. |
If the file is an HTML file, and the suggestion is within a In Vue SFC, it's more complicated, the |
I would argue that syntax highlighting is not feasible. The resulting code block would be rendered with diff syntax. - remove this
+ replace with this Adding syntax highlighting for a different language (rendered within the |
Description
GitHub supports the option to add code suggestions that can automatically overwrite the current code if committed. The user has the option to add infinitely many suggestions together in a batch before committing all in one single code review commit.
Any code review comment can contain suggestions by simply using
The text that gets replaced is the text selected for this comment, resulting in this issue being effectively blocked until #12640 gets merged.
Of course, it would already be possible to implement, but limited to single-line code suggestions for now.
Later on, this feature could even be enhanced to use additional language highlighting, so that the recommendations would even be displayed in the style of the given language. This could look something like this then:
, for example
This is a useful feature as it allows integrating code suggestions way quicker and without the help of any external tool, where each change has to be manually located first.
Screenshots
Current design on GitHub:
behavior when there are multiple suggestions in one comment:
The text was updated successfully, but these errors were encountered: