Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Deleting text disables recommendations #15837

Closed
delvh opened this issue May 11, 2021 · 2 comments
Closed

[Bug] Deleting text disables recommendations #15837

delvh opened this issue May 11, 2021 · 2 comments
Labels
outdated/theme/markdown topic/ui-interaction Change the process how users use Gitea instead of the visual appearance type/bug

Comments

@delvh
Copy link
Member

delvh commented May 11, 2021

  • Gitea version (or commit ref): 1.15.0+dev-274-g143071ee4 and every single one below
  • Can you reproduce the bug at https://try.gitea.io: Yes

Description

When a user enters text that requests recommendations (either the emoji :, the user mentioning @ or maybe later on the issue linking # syntax), recommendations will not get updated after text has been deleted from the input (i.e. removing the e from :smile ). This means the recommendations popup will be frozen in place, not changing for any input.
There are currently two ways to force the menu to close:
A) The textarea loses focus
B) Every part of the recommendation requesting input gets deleted (i.e. even the : of :smile)

It would be nice if the recommendations would also get updated when text is deleted and afterwards.

Screenshots

Screenshot_20210511_235746
In this screenshot, I entered :smile, then replaced it with :build. As you can see, the menu did not get updated and is now frozen.

@a1012112796 a1012112796 added the topic/ui Change the appearance of the Gitea UI label May 12, 2021
@wxiaoguang
Copy link
Contributor

Resolved by #23985 ?

@delvh
Copy link
Member Author

delvh commented Apr 12, 2023

Yup.
Finally. I had a feeling when reviewing that PR that I missed an issue that is fixed by it 😃

@delvh delvh closed this as completed Apr 12, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2023
@delvh delvh added topic/ui-interaction Change the process how users use Gitea instead of the visual appearance and removed topic/ui Change the appearance of the Gitea UI kind/usability labels Oct 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated/theme/markdown topic/ui-interaction Change the process how users use Gitea instead of the visual appearance type/bug
Projects
None yet
Development

No branches or pull requests

4 participants