Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arbitrary PR id in PR URL always leads to first PR in repository #16405

Closed
2 of 6 tasks
flozzone opened this issue Jul 12, 2021 · 0 comments · Fixed by #16406
Closed
2 of 6 tasks

Arbitrary PR id in PR URL always leads to first PR in repository #16405

flozzone opened this issue Jul 12, 2021 · 0 comments · Fixed by #16406
Labels
Milestone

Comments

@flozzone
Copy link
Contributor

  • Gitea version (or commit ref): 1.14.4
  • Git version:
  • Operating system: Docker container
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
  • Log gist:

Description

For a PR URL with a unparseable PR id like https://try.gitea.io/our-org/custom-project/pulls/[WRONGSYNTAX] the resulting PR is always the first PR in the project, instead of showing a 404 page. Constructing URLs like this can result in wrong URLs and should therefore also result in a 404 page.

...

Screenshots

@noerw noerw added the type/bug label Jul 12, 2021
@6543 6543 added this to the 1.15.0 milestone Jul 12, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants