Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent double close comments #18330

Open
qwerty287 opened this issue Jan 19, 2022 · 2 comments
Open

Prevent double close comments #18330

qwerty287 opened this issue Jan 19, 2022 · 2 comments

Comments

@qwerty287
Copy link
Contributor

Feature Description

Gitea should prevent close comments if the issue is already closed (just don't add another comment). This happens while merging a PR with squash merge - one close comment comes from the PR desc (close #...) and one from the merge commit if the PR desc is also the commit message.

Screenshots

This example comes from https://codeberg.org/gitnex/GitNex/issues/985#event-291274

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Jan 19, 2022

That's a long story and duplicated of #17111
We could close this one

update: this seems a new problem.

@wxiaoguang
Copy link
Contributor

Hmm ... maybe we could do some backend work for the Close action only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants