Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stopped redirecting when using lowercase repo names #18774

Closed
AbdulrhmnGhanem opened this issue Feb 15, 2022 · 0 comments
Closed

Stopped redirecting when using lowercase repo names #18774

AbdulrhmnGhanem opened this issue Feb 15, 2022 · 0 comments
Labels
type/enhancement An improvement of existing functionality

Comments

@AbdulrhmnGhanem
Copy link
Contributor

AbdulrhmnGhanem commented Feb 15, 2022

Gitea Version

609c916

Git Version

No response

Operating System

No response

How are you running Gitea?

https://try.gitea.io

Database

No response

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Description

  • Previously, GET {username}/{reponame}/raw///file-path (the middle two slashes are blank to get the default branch) when the repo name has uppercase letters, e.g., https://try.gitea.io/AbdulrhmnGhanem/CH330_Hardware, using a lowercase version of the name redirected to the correct URL

  • In other words, both

    • GET https://try.gitea.io/AbdulrhmnGhanem/CH330_Hardware/raw///images/back.png
    • GET https://try.gitea.io/AbdulrhmnGhanem/ch330_hardware/raw///images/back.png

    were redirecting to
    GET https://try.gitea.io/AbdulrhmnGhanem/CH330_Hardware/raw/branch/master/images/back.png
    This isn't the case after Multiple Escaping Improvements #17551. Specifically because of this line.

Screenshots

No response

@lunny lunny added the type/enhancement An improvement of existing functionality label Feb 16, 2022
@lunny lunny closed this as completed Feb 17, 2022
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/enhancement An improvement of existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants